Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

Scan /Applications in newly mounted partitions #51

Open
probonopd opened this issue Dec 3, 2018 · 4 comments
Open

Scan /Applications in newly mounted partitions #51

probonopd opened this issue Dec 3, 2018 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help-wanted Extra attention is needed

Comments

@probonopd
Copy link
Member

probonopd commented Dec 3, 2018

Instead of scanning a fixed set of locations like

  • /isodevice/Applications
  • /isofrom/Applications
  • /run/initramfs/isoscan/Applications
  • /run/archiso/img_dev/Applications
  • /lib/live/mount/findiso/Applications

we should scan /Applications in every mounted partition.

This would give us support for distirbutions like Manjaro, where the Live medium is mounted at /run/miso/img_dev, without having to hardcode yet another location.

As a bonus, we should also monitor /Applications on freshly mounted partitions as they come and go (think removable drives).

@rszibele, do you want to have a go at this?

@probonopd probonopd added enhancement New feature or request good first issue Good for newcomers labels Dec 3, 2018
@probonopd
Copy link
Member Author

I have implemented this in 660c916 but we still need to make appimaged aware of newly mounted and unmounted partitions, possibly using something like UDisks and dbus.

@probonopd probonopd changed the title Scan /Applications in every mounted partition Scan /Applications in newly mounted partitions Dec 6, 2018
@probonopd
Copy link
Member Author

@TheAssassin suggested just running the code that scans the mountpoints after every few seconds.

Not sure whether UDisks/dbus wouldn't be more suitable.

660c916#r31601615

@TheAssassin
Copy link
Member

It'll surely be the better solution, but I guess periodic scanning could be used as a fallback (you could also simply combine both). I think a scanning interval of 1 min would be viable.

@probonopd
Copy link
Member Author

When you attach a new disk it needs to be "instant" - or do you want to plug in a USB stick and wait for a minute?

@probonopd probonopd added the help-wanted Extra attention is needed label Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants