Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

tslint doesn't honor lintOnChange #220

Closed
jfrancos opened this issue Mar 2, 2018 · 3 comments
Closed

tslint doesn't honor lintOnChange #220

jfrancos opened this issue Mar 2, 2018 · 3 comments

Comments

@jfrancos
Copy link

jfrancos commented Mar 2, 2018

I have "Lint on Change" set in Linter, and this works fine with eslint. But for tslint, linting does not seem to happen until I save the file.

@AlexanderOMara
Copy link

If you have the semantic rules option enabled, I suspect #222 details your issue.

@madhums
Copy link

madhums commented Feb 20, 2019

Perhaps it is related to this piece of code https://github.com/AtomLinter/linter-tslint/blob/master/lib/main.js#L146

  // ...
  provideLinter() {
    return {
      name: 'TSLint',
      grammarScopes,
      scope: 'file',
      lintsOnChange: true, // <-- This should probably read from atom.config?
      lint: async (textEditor) => {
  // ...

I suppose the line that reads lintsOnChange: true should read from atom.config?

@Arcanemagus
Copy link
Member

I'm not sure what you are trying to say there... this provider doesn't have a setting to override that.

I'm going to assume that @AlexanderOMara was correct in their assumption that this is a duplicate of #222. Since @jfrancos never responded though we'll likely never know for sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants