Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide other padding options in paganin_filter_tomopy #155

Open
yousefmoazzam opened this issue Sep 19, 2024 · 1 comment
Open

Provide other padding options in paganin_filter_tomopy #155

yousefmoazzam opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@yousefmoazzam
Copy link
Contributor

Just to improve the visibility of this TODO I saw in a code comment so it's less likely to get missed:

# Perform padding to the power of 2 as FFT is O(n*log(n)) complexity
# TODO: adding other options of padding?
padded_tomo, pad_tup = _pad_projections_to_second_power(tomo)

@yousefmoazzam yousefmoazzam added the enhancement New feature or request label Sep 19, 2024
@dkazanc
Copy link
Collaborator

dkazanc commented Sep 27, 2024

I guess there are 2 things, padding in a sense of extending the area and also filling the padding area with some values. This comment refers to the former but it could be the latter that it is more important. Apparently, padding with zero values can be not the best choice.
Coming back to this issue, I'm not sure what exactly we gain if we do the padding area smaller for instance. It requires a bit of benchmarking first, but I think initially this was a comment to deal with the fact that in TomoPy they do not scale to the power of 2. Which is good when the memory is in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants