Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Anomaly #1373

Open
f1am3d opened this issue Jun 18, 2023 · 13 comments
Open

Support for Anomaly #1373

f1am3d opened this issue Jun 18, 2023 · 13 comments
Labels
AI Artificial Intelligence Call of Pripyat This can affect Call of Pripyat compatibility, or related to this game. Enhancement Gameplay good first issue Good start for beginners that want to contribute. Help wanted Lua Modmaker Experience Modmaker experience with OpenXRay Mods This issue is related to mods. UI

Comments

@f1am3d
Copy link

f1am3d commented Jun 18, 2023

Is your feature request related to a problem? Please describe.
I would like to create a new branch and adapt this engine for Stalker Anomaly, since its own fork is only contains game-logic changes but the performance is awful.

Describe the solution you'd like
Create new branch /anomaly and apply/refactor changes from here: https://bitbucket.org/anomalymod/xray-monolith/commits/ to make this fork compatible with Anomaly mod.

Additional context
I believe this will benefit both the playerbase and the team of this fork, due to the increased popularity.

@Xottab-DUTY
Copy link
Member

Do you need any help with that?

@ChugunovRoman was working on merging Call of Chernobyl to the latest OpenXRay. Anomaly is based on CoC, so Roman's work can help really much!

@Xottab-DUTY Xottab-DUTY added Enhancement Help wanted AI Artificial Intelligence Gameplay UI Lua Modmaker Experience Modmaker experience with OpenXRay Call of Pripyat This can affect Call of Pripyat compatibility, or related to this game. Mods This issue is related to mods. good first issue Good start for beginners that want to contribute. labels Jun 18, 2023
@f1am3d
Copy link
Author

f1am3d commented Jun 18, 2023

@Xottab-DUTY Yes, I could use some help.
I plan to investigate conflicting parts of the code between these two to see where code cannot be simply copy-pasted from anomaly sources. There will be needed merging and refactoring.
I think at first it would be correct to transfer only the mod logic, without touching parts related to the core engine's functionality.

@LVutner
Copy link
Contributor

LVutner commented Jun 22, 2023

I suggest to compare Anomaly code against: https://bitbucket.org/SeargeDP/coc-1.4-xray-64/src
Then, you can see what was added/removed/changed. Should be easier to port Anomaly functionality onto OpenXRay engine.

@LVutner
Copy link
Contributor

LVutner commented Jun 22, 2023

Most of the render code (excluding features required/accessed by LUA) can be ignored.

@Xottab-DUTY
Copy link
Member

@ChugunovRoman, could you give a tip about branches in your fork?
https://github.com/ChugunovRoman/xray-16

I see there are coc and future_changes_for_coc branches. Which should be used and what changes they contain?

@ChugunovRoman
Copy link
Contributor

I see there are coc and future_changes_for_coc branches. Which should be used and what changes they contain?

@Xottab-DUTY The future_changes_for_coc branch include all latest changes which I moved from the CoC Engine

@yohjimane
Copy link
Contributor

This may have some overlap with the work I'm doing for #1398, as I have to port some anomaly functionality to support the shaders

@mbehm
Copy link

mbehm commented Oct 20, 2023

I suggest to compare Anomaly code against: https://bitbucket.org/SeargeDP/coc-1.4-xray-64/src Then, you can see what was added/removed/changed. Should be easier to port Anomaly functionality onto OpenXRay engine.

I don't know if this has gotten anywhere since the last comments here but I did take a quick look on doing the comparison. A quick initial diff was around million lines, after heavy filtering of all whitespace etc. changes we're left with about 55k lines of diffs that should contain all the actually meaningful changes, here's a repo for the generation and filtered diffs https://github.com/mbehm/xray-monolith-diffs

@mbehm
Copy link

mbehm commented Oct 25, 2023

Small status update

I've created a branch with all the filtered diffs applied to a copy of the base coc src, you can find the changes here.

Next I'll start to go through the individual change hunks and split them to feature/lua-scripting etc. branches. Starting with misc cleanup etc. to get them out of cluttering the rest of the logic changes.

There's about 2.3k hunks so not too bad but I'm not sure how much time I'll have to work on it so might take few weeks to sort through them.

@Xottab-DUTY
Copy link
Member

@mbehm, one thing to make sure: did you compared Anomaly against SeargeDP's CoC x64 repository?

@mbehm
Copy link

mbehm commented Oct 26, 2023

@mbehm, one thing to make sure: did you compared Anomaly against SeargeDP's CoC x64 repository?

Yes the diffs are based on that and the current demonized xray-monolith repository.

@Xottab-DUTY
Copy link
Member

I created a new task for Call of Chernobyl support (#1529). We should solve it first, before attempting to launch Anomaly.

@f1am3d
Copy link
Author

f1am3d commented Dec 22, 2023

Related #1567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Artificial Intelligence Call of Pripyat This can affect Call of Pripyat compatibility, or related to this game. Enhancement Gameplay good first issue Good start for beginners that want to contribute. Help wanted Lua Modmaker Experience Modmaker experience with OpenXRay Mods This issue is related to mods. UI
Projects
Status: To do
Development

No branches or pull requests

6 participants