Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Custom item gives a LUA script error onMouseOver of the Create button` #7175

Closed
2 tasks done
jwusch opened this issue Dec 27, 2023 · 2 comments
Closed
2 tasks done
Labels
bug Something isn't working crash Causes PoB to crash and is High Priority

Comments

@jwusch
Copy link

jwusch commented Dec 27, 2023

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Screenshots of crash/graphical issue, version and options menu

DOing the copy and paste of this item from POE, gives a LUA type conversion error on this screen.
image
image

What are your system specifications and configuration?

Windows 10, 4090.

How to reproduce the issue

Paste this text from POE into the "Create Custom Item" dialog box

Item Class: Rings
Rarity: Rare
Kraken Twirl
Unset Ring

Requirements:
Level: 67

Sockets: R

Item Level: 84

{ Implicit Modifier }
Has 1 Socket (implicit)

{ Prefix Modifier "Vaporous" (Tier: 1) — Defences, Evasion }
+163(151-170) to Evasion Rating
{ Suffix Modifier "of Cinders" (Tier: 2) — Damage, Elemental, Fire }
14(13-17)% increased Fire Damage
{ Suffix Modifier "of the Lizard" (Tier: 6) — Life }
Regenerate 7.5(2.1-8) Life per second
{ Suffix Modifier "of Light" (Tier: 2) — Attack }
15(12-15)% increased Global Accuracy Rating
10% increased Light Radius

Character build code

No response

@jwusch jwusch added bug Something isn't working crash Causes PoB to crash and is High Priority labels Dec 27, 2023
@Paliak
Copy link
Contributor

Paliak commented Dec 29, 2023

This seems to be caused by precision mod parsing logic

line = line:gsub("(%+?)%((%-?%d+%.?%d*)%-(%-?%d+%.?%d*)%)",
function(plus, min, max)
numbers = numbers + 1
local power = 10 ^ (precision or 0)
local numVal = m_floor((tonumber(min) + range * (tonumber(max) - tonumber(min))) * power + 0.5) / power
return (numVal < 0 and "" or plus) .. tostring(numVal)
end)
:gsub("%-(%d+%%) (%a+)", antonymFunc)

Turning the line Regenerate 7.5(2.1-8) Life per second into Regenerate 7.55.1 Life per second which is parsed into a mod with the value of "7.55.1" making this line:

result = result + mod.value

cause the crash.

@Wires77
Copy link
Member

Wires77 commented Dec 29, 2023

The real issue is that PoB doesn't support advanced copy/paste (Ctrl+Alt+C). Use normal item copy for now (Ctrl+C). Duplicate of #2684

@Wires77 Wires77 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Causes PoB to crash and is High Priority
Projects
None yet
Development

No branches or pull requests

3 participants