Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod install reasons #1617

Open
1 task done
TwistedAkai opened this issue Nov 17, 2023 · 2 comments
Open
1 task done

Mod install reasons #1617

TwistedAkai opened this issue Nov 17, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@TwistedAkai
Copy link

Role

I frequently add a few mods onto mod packs

Suggestion

Track mod install reason: Modpack, explicit, dependency

Benefit

To improve update checking

This suggestion is unique

  • I have searched the issue tracker and did not find an issue describing my suggestion, especially not one that has been rejected.

You may use the editor below to elaborate further.

I'd like to see PolyMC record a "reason" for why a mod is added to an instance, similar to linux package managers. Presently, this would have little immediate impact but would enable other requested features.

Reasons could be used to inform update checking: Modpack mods could be skipped over in lieu of checking for a new version of the pack itself. If the modpack removes the mod or changes it's version in an update, the update checker can assume it should update/remove the mod accordingly. #65 #324 #1591
Explicit mods could be handled the way all mods presently are, and dependencies could be checked either the same, or only when their dependents have updates.
Regardless, if a mod is removed, or at the user request, mods with the dependency reason should be checked for dependents that have a different install reason. If there are none, suggest removal.

Reasons could also be displayed in the mod list, to assist users in managing their own additions to packs.

@TwistedAkai TwistedAkai added the enhancement New feature or request label Nov 17, 2023
@TwistedAkai
Copy link
Author

Added bonus would be to enable users to set reasons, for example: setting a mod as being a dependency of another mod, rather than an explicit install.

@ghost
Copy link

ghost commented Nov 24, 2023

This is a good idea, but should likely be roped in with modpack updates. Not a huge change as long as we don't break the MultiMC zip format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant