Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[✨] Make qwik / eslint-plugin-qwik compatible with ESLint version 9 #30

Closed
orbanszlrd opened this issue Aug 7, 2024 · 5 comments
Closed
Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation

Comments

@orbanszlrd
Copy link

orbanszlrd commented Aug 7, 2024

Is your feature request related to a problem?

qwik / eslint-plugin-qwik depends on an older version of ESLint and can't be used with the latest versions (9.0.0 and above).
Please update the dependencies and migrate your config file.
Thank you in advance!

Describe the solution you'd like

  1. Update the dependencies in the package.json:
-       "@types/eslint": "^8.56.10",
-       "@typescript-eslint/eslint-plugin": "^7.16.1",
-       "@typescript-eslint/parser": "^7.16.1",
-       "eslint": "^8.57.0",
+       "@types/eslint": "^9.6.0",
+       "@typescript-eslint/eslint-plugin": "^8.0.1",
+       "@typescript-eslint/parser": "^8.0.1",
+       "eslint": "^9.8.0",
  1. Migrate the config file as described here: https://eslint.org/docs/latest/use/configure/migration-guide
  2. Delete the .eslintignore as it's no longer needed

Describe alternatives you've considered

no alternatives

Additional context

image

@gioboa
Copy link
Member

gioboa commented Aug 7, 2024

Hi @orbanszlrd thanks for the report. As you can see here the Qwik team is looking to switching to Biome.

@orbanszlrd
Copy link
Author

Yes, I saw that, but I suspect it's more work. When is the transition expected? Does this also mean that the ESLint update is not on the agenda?

@gioboa
Copy link
Member

gioboa commented Aug 7, 2024

As a team we decided to switch to Biome and move the eslint as a community integration.
We are working on Biome integration, you can help us if you want btw

@orbanszlrd
Copy link
Author

Thanks for the information, @gioboa !

@gioboa
Copy link
Member

gioboa commented Oct 14, 2024

We moved this issue to qwik-evolution repo to create a RFC discussion for this.
Here is our Qwik RFC process thanks.

@gioboa gioboa transferred this issue from QwikDev/qwik Oct 14, 2024
@github-actions github-actions bot added [STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation labels Oct 14, 2024
@QwikDev QwikDev locked and limited conversation to collaborators Oct 14, 2024
@gioboa gioboa converted this issue into discussion #106 Oct 14, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
[STAGE-2] incomplete implementation Remove this label when implementation is complete [STAGE-2] not fully covered by tests yet Remove this label when tests are verified to cover the implementation [STAGE-2] unresolved discussions left Remove this label when all critical discussions are resolved on the issue [STAGE-3] docs changes not added yet Remove this label when the necessary documentation for the feature / change is added [STAGE-3] missing 2 reviews for RFC PRs Remove this label when at least 2 core team members reviewed and approved the RFC implementation
Projects
None yet
Development

No branches or pull requests

2 participants