Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when protected resource deligate is nil. #159

Open
jpittis opened this issue Jul 12, 2017 · 0 comments
Open

Throw exception when protected resource deligate is nil. #159

jpittis opened this issue Jul 12, 2017 · 0 comments
Assignees

Comments

@jpittis
Copy link
Contributor

jpittis commented Jul 12, 2017

Because we can now disable bulkheads or circuit_breakers for a protected_resource, we should raise an exception trying to access methods of a nil delegate.

For example, with bulkhead: false, resource.count should raise a BulkheadDisabledError rather than a NoMethodError kinda thing.

We should also add something to the docs that recommends using resource.bulkhead.count over resource.count.

cc @sirupsen @csfrancis

@jpittis jpittis self-assigned this Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant