Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for 'mob heads on note blocks interaction sound' to client versions lower than 1.19.3 #534

Closed
Pantera07 opened this issue Mar 18, 2023 · 5 comments
Labels
Feature Request Suggest a change/feature

Comments

@Pantera07
Copy link
Contributor

Problem Description

In clients with versions lower than 1.19.3, the 'mob heads on note blocks interaction' sound from 1.19.3 and 1.19.4 servers cannot be heard. As it is scheduled to be officially added in 1.20, it would be great if players could hear the mob sound in versions lower than 1.19.3.

Solution Description

Even if the client version is lower than 1.19.3, it has the mob sound resource, so it should be possible to enable players to hear it.

Alternatives

No response

Additional Info

1

@Pantera07 Pantera07 added the Feature Request Suggest a change/feature label Mar 18, 2023
@kennytv
Copy link
Member

kennytv commented Mar 18, 2023

@kennytv kennytv closed this as not planned Won't fix, can't repro, duplicate, stale Mar 18, 2023
@Pantera07
Copy link
Contributor Author

See #326 (specifically: https://github.com/ViaVersion/Mappings/blob/main/mappings/diff/mapping-1.19.3to1.19.json#L785)

Thank you. I will help with the sound mapping.

@Pantera07
Copy link
Contributor Author

I tried ViaBackwards Build #308, but I still can't hear mob sounds from the note block.
https://ci.viaversion.com/view/ViaBackwards/job/ViaBackwards/lastSuccessfulBuild/

@kennytv
Copy link
Member

kennytv commented Mar 18, 2023

Works fine for me now, make sure you're not getting the wrong build(s) due to caching

@Pantera07
Copy link
Contributor Author

It works fine now after downloading it again! It seems like the previous version's cache was downloaded because I downloaded it with the lastSuccessfulBuild address. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest a change/feature
Projects
None yet
Development

No branches or pull requests

2 participants