Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored item name inside shulker box is not displayed properly on clients 1.12.2 and below #587

Open
4 tasks done
D4rthS1d10u5 opened this issue Sep 6, 2023 · 1 comment

Comments

@D4rthS1d10u5
Copy link

'/viaversion dump' Output

https://dump.viaversion.com/abd0389fdcc75e8e21489c9e19848c503f78b9957a867814cd4a1993cd8863b5

Console Error

There are no errors displayed in the console.

Bug Description

Upon hovering on shulker box that contains item with name colored using legacy-formatted text it is displayed as JSON value. Similar behavior is described in the issue #575.

изображение

Steps to Reproduce

  1. Log in with 1.12.2 client.
  2. Take an empty shulker box.
  3. Obtain item with colored name.
  4. Put the item inside a shulker box.
  5. Break the shulker box and hover the cursor over it.

Expected Behavior

Item display name shoud be seen with colors and formatting like this:

изображение


I found that when an item is displayed inside a container, such as a player's inventory, its name is colored as expected.

изображение

Such effect is achieved by using tags that contain original text data: VB|Protocol1_12_2To1_13|2|Name for item display name and VB|Protocol1_13_2To1_14|oLore for lore respectively. And then plugin attaches legacy-formatted text inside Name and Lore tags.

Maybe it is possible to implement the same mechanism for display names inside shulker boxes?

Additional Server Info

No response

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. BungeeCord), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried a build from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Sep 6, 2023

Platform: git--Paper--794%20%28MC%3A%201.16.5%29
ViaVersion (4.7.1-SNAPSHOT): Even with master
ViaRewind(2.0.3): 19 commits behind master
ViaBackwards(4.7.1-SNAPSHOT): Even with master

Please try the latest build(s) from https://ci.viaversion.com/. In case the issue still persists send the new dump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants