Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Data in Chat Component Hover Events do not display on 1.20.4 client on 1.20.6 server #788

Open
4 tasks done
XDMAN500 opened this issue Jun 16, 2024 · 6 comments
Open
4 tasks done
Labels

Comments

@XDMAN500
Copy link

XDMAN500 commented Jun 16, 2024

'/viaversion dump' Output

https://dump.viaversion.com/f607ade2ea7059165718592ab2768758d6125a478c523a89c8e5d34e753e0367

Console Error

N/A

Bug Description

The item data in chat hover events on 1.20.6 servers are not properly translated to 1.20.4 clients so item data like custom names, enchantments, attributes, and others are not visible to 1.20. clients.

Steps to Reproduce

  1. Start a server with 1.20.6
  2. Join server with a 1.20.4 client
  3. Execute command tellraw @a {"text":"Hover me!","hoverEvent":{"action":"show_item","contents":{"id":"cake","count":1, "components":{"cu stom_name":"{'text':'Special Cake Name',color:'yellow'}"}}}}
  4. The 1.20.4 client hovers over the chat message and only sees a default cake item
  5. A 1.20.6 client client sees a cake with a yellow custom name "Special Cake name"

Expected Behavior

The 1.20.4 client should see the "Special Cake Name" custom name on the cake item when hovering over the chat message.

Additional Server Info

Appearance from a 1.20.4 client
image

Appearance from a 1.20.6 client
image

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried a build from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Jun 16, 2024

Platform: 1.20.6--112--347bbe3%20%28MC%3A%201.20.6%29
ViaVersion (5.0.0): 4 commits behind master
ViaBackwards(5.0.0): Even with master

Please update all Via* plugins from https://ci.viaversion.com/.In case the issue still persists send the new dump and the issue will be reopened

@Barvalg Barvalg closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2024
@kennytv
Copy link
Member

kennytv commented Jun 16, 2024

Known, but it'll take a bit to fix

@XDMAN500
Copy link
Author

@Barvalg
Copy link
Member

Barvalg commented Jun 16, 2024

Platform: 1.20.6--112--347bbe3%20%28MC%3A%201.20.6%29
ViaVersion (5.0.1-SNAPSHOT): Even with master
ViaBackwards(5.0.0): Even with master

@Barvalg Barvalg reopened this Jun 16, 2024
@Barvalg Barvalg removed the invalid label Jun 16, 2024
@kennytv kennytv added bug and removed unconfirmed labels Jun 20, 2024
@Kryniowesegryderiusz
Copy link

Is there any eta for that? 👉👈

@FlorianMichael
Copy link
Member

No, writing these conversions is quite time intensive and it will take a while, but I plan on doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants