Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolving peer dependency warnings for react 17 #158

Open
nikitr opened this issue Jul 12, 2022 · 2 comments
Open

resolving peer dependency warnings for react 17 #158

nikitr opened this issue Jul 12, 2022 · 2 comments

Comments

@nikitr
Copy link

nikitr commented Jul 12, 2022 •
edited
Loading

can we update the react dependencies in the package.json to remove these warnings?

warning " > [email protected]" has incorrect peer dependency "react@^16.8.0".
warning " > [email protected]" has incorrect peer dependency "react-dom@^16.8.0".

for context, our project is on react 17. would we be able to add

"peerDependencies": {
    "react": "^16.8 || ^17.0",
    "react-dom": "^16.8 || ^17.0",
  },
@nikitr nikitr changed the title Is there a way to update the react dependencies in the package.json to remove these warnings? Can we add a peer dependency to react-resource-router for react 17 to eliminate some warnings in our project? Jul 13, 2022
@nikitr nikitr changed the title Can we add a peer dependency to react-resource-router for react 17 to eliminate some warnings in our project? resolving peer dependency warnings for react 17 to eliminate some warnings in our project? Jul 14, 2022
@nikitr nikitr changed the title resolving peer dependency warnings for react 17 to eliminate some warnings in our project? resolving peer dependency warnings for react 17 Jul 14, 2022
@theKashey
Copy link
Collaborator

Let's include 18 as well. Not sure if React 17 is really used anywhere around - it was quite a temporal version.

@nikitr
Copy link
Author

nikitr commented Jul 18, 2022

ok thanks @theKashey what will the timeline look like on updating this peer dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theKashey @nikitr