Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

"Featured Packages" is showing featured themes as well #1090

Open
1 task done
Arcanemagus opened this issue Nov 2, 2018 · 1 comment
Open
1 task done

"Featured Packages" is showing featured themes as well #1090

Arcanemagus opened this issue Nov 2, 2018 · 1 comment

Comments

@Arcanemagus
Copy link
Contributor

Prerequisites

Description

The list of Featured Themes is being added to the list of Featured Packages.

Steps to Reproduce

  1. Open Atom in Safe Mode
  2. Go to Settings -> Install
  3. Look at the list of Featured Packages

Expected behavior:

Only packages show in the Featured Packages.

Actual behavior:

Themes are showing in the package list:
image

Reproduces how often:

100% of the time.

Versions

OS: Windows 10 x64

Atom    : 1.34.0-nightly8
Electron: 2.0.12
Chrome  : 61.0.3163.100
Node    : 8.9.3
apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.34.0-nightly8
python 2.7.15
git 2.19.1.windows.1
visual studio 2015

Additional Information

Looks like this is the inverse of #304.

@50Wliu
Copy link
Contributor

50Wliu commented Nov 3, 2018

👍 from me on adding a --packages argument to apm and simply propagating that flag in settings-view rather than trying to filter out themes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants