Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random rainbow highlights when editing after first-time load #15

Open
imkiva opened this issue Nov 16, 2021 · 2 comments
Open

Random rainbow highlights when editing after first-time load #15

imkiva opened this issue Nov 16, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@imkiva
Copy link
Member

imkiva commented Nov 16, 2021

Related code: https://github.com/banacorn/agda-mode-vscode/blob/master/src/Highlighting.res#L87

It's very annoying to keep semantic tokens in sync with user edits manually. I decide to simply remove highlights when editing until we have a better way to update highlights as user types, or we just compromised.
@imkiva imkiva added the bug Something isn't working label Nov 16, 2021
@imkiva imkiva changed the title Randomly rainbow highlight when editing after first-time load Random rainbow highlights when editing after first-time load Nov 16, 2021
@imkiva imkiva closed this as completed in e4a5720 Nov 16, 2021
@imkiva
Copy link
Member Author

imkiva commented Nov 16, 2021

Reopen since it is not really fixed.

@imkiva imkiva reopened this Nov 16, 2021
@ice1000
Copy link
Member

ice1000 commented Nov 16, 2021

I am happy with this solution! It seems okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imkiva @ice1000