Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bacalhau config set --config=config.yaml <key> <value> fails if config.yaml doesn't exist #4530

Open
frrist opened this issue Sep 25, 2024 · 2 comments
Labels
comp/cli Anything that affects the command-line interface th/config Theme: Related to configuration files and settings across the project th/game-day Issues reported during game day testing type/bug Type: Something is not working as expected

Comments

@frrist
Copy link
Member

frrist commented Sep 25, 2024

Bug Description

This appears to be a regression introduced via #4466

bacalhau config set --config=config.yaml datadir /some/path
invalid argument "config.yaml" for "-c, --config" flag: the specified configuration file "config.yaml" doesn't exist
@frrist frrist added type/bug Type: Something is not working as expected comp/cli Anything that affects the command-line interface th/config Theme: Related to configuration files and settings across the project th/game-day Issues reported during game day testing labels Sep 25, 2024
@wdbaruni
Copy link
Member

Wasn't regression but intentional. if the user miss typed a config file name I would prefer it fails than assuming it wrote to the correct file and create a new one instead

@frrist
Copy link
Member Author

frrist commented Sep 25, 2024

I thought the behavior we wanted was to create a config file if one didn't exist? Right now, the current behavior is that config set will create a config file in the repo is one doesn't exist. But, for example re-suing the above command, bacalhau will not create the config.yaml file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp/cli Anything that affects the command-line interface th/config Theme: Related to configuration files and settings across the project th/game-day Issues reported during game day testing type/bug Type: Something is not working as expected
Projects
Status: Inbox
Development

No branches or pull requests

2 participants