-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Colored annotations and additional fields to pass to the template #2
Comments
@jun6lee Thank you for your interest in the plugin.
Would it make more sense for you to update the PR to introduce colors for the highlights? Without it, the PR looks a bit unfinished. Ultimately, these changes can then be reflected in documentation as "advanced" template customization for those who want (or need) color differentiation in their book highlights. What do you think? Thanks |
Sure thing. I was looking to do something like this which I was using on another plugin:
|
If you could push what I've added so far, I can test this and share an advanced_template file in a day or two. Would that work for you? |
I also think I may need to add an apple date converter proc, which I have on standby. |
const APPLE_EPOCH_START = new Date("2001-01-01").getTime(); and feed the ZANNOTATIONMODIFICATIONDATE or ZANNOTATIONCREATIONDATE something like this:
using
|
@jun6lee Thanks for sharing.
I see no problems integrating colors into the template and provide it as an example of advanced customization. You also saved me time for testing the mapping of
I'm now in the middle of releasing a new version and will get back to the colored template in a day or two as well, so basically I can pick up your PR #1 where you left off and add all the necessary changes, if you don't mind. As for the time, it looks doable, but it's definitely a separate improvement. I would like to check it on my side. |
Works for me, no rush. :) |
Have raised a PR for the same.
Aiming for something like this:
Will share a suggested template for anyone looking to do the same, once we have the fields.
The text was updated successfully, but these errors were encountered: