Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted books still displayed in ibook export options #48

Open
ghost opened this issue May 12, 2023 · 14 comments
Open

Deleted books still displayed in ibook export options #48

ghost opened this issue May 12, 2023 · 14 comments
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 12, 2023

Deleted books (from Apple Books) are still displayed in book export options. Reinstalling ibook plugin, logging out of iCloud, and restarting the workstation does not resolve the issue. Is there a way to clear the cache or folder?

@bingryan
Copy link
Owner

ibook: the book is deleted, but the annotations in the ibook will not be deleted

@bingryan
Copy link
Owner

Can you describe the feature you want?

@ghost
Copy link
Author

ghost commented May 13, 2023

When running the ibook export command, ibook is listing books that are not in my library (they were deleted a long time ago). Where is it getting the list? No feature is needed - only a fix.

@bingryan
Copy link
Owner

When running the ibook export command, ibook is listing books that are not in my library (they were deleted a long time ago). Where is it getting the list? No feature is needed - only a fix.

from ibook local sqlite db

@bingryan
Copy link
Owner

for #40, some people also want to keep this historical information 🤣

@ghost
Copy link
Author

ghost commented May 13, 2023

#40 is for delta sync of annotations of deleted books. Other people want to keep the annotations. I have no annotations or books in my Books app library. Everything has been deleted. But, ibook plugin shows previously deleted pdfs and book samples. It's a different issue.

@bingryan
Copy link
Owner

maybe you can export-single-book-by-search, not export all .

@ghost
Copy link
Author

ghost commented May 14, 2023

I'm already using it. It lists 20 books I don't have in my library. 🤷‍♂️

@bingryan
Copy link
Owner

If you really don't want to list books that are not on your library, I will add toggle setting to filter deleted book.

@ghost
Copy link
Author

ghost commented May 14, 2023

A toggle to hide deleted books would be helpful. Many people download many book samples and pdfs only to view them temporarily in Apple Books.

Thank you for the plugin and your support. 👍

@bingryan bingryan added the enhancement New feature or request label May 14, 2023
@bingryan
Copy link
Owner

I reorganized the logic, you should delete the records on icloud, but not delete the local records. when you delete book, you should choice "delete all"

@bingryan
Copy link
Owner

The current logic is based on the ibook library, if you delete book, you will choice delete all(icloud / local), the book info will not at library(and local sqlite db will delete this record)

@bingryan
Copy link
Owner

the version of my ibook is 5.1 (5743), I don't know if yours is the same version

@jun6lee
Copy link

jun6lee commented Jul 14, 2023

I think it's not really something in the purview of the plugin, although the toggle would be a nice to have.
If the sql file contains deleted books and highlights, this might be something Apple simply wants to hold on to.

They have the same logic when it comes to apps purchased on the App Store, you can hide them, but never really delete them from your iCloud account history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants