Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Will ISO-3166-3 be supported? #64

Open
jakewilliami opened this issue Nov 6, 2023 · 3 comments
Open

Will ISO-3166-3 be supported? #64

jakewilliami opened this issue Nov 6, 2023 · 3 comments

Comments

@jakewilliami
Copy link

I notice you have a data file for ISO-3166-3, but I can't (for example) find SU. Are you planning on supporting these?
@biter777
Copy link
Owner

biter777 commented Nov 9, 2023

The code was removed from ISO 3166-1 in 1992.
Explain in more detail for what purpose you need to include obsolete code?

@jakewilliami
Copy link
Author

I'm pulling top level domains from the IANA TLD database, and if they are country-code TLDs, I am using your library to cross-reference using country code.

SU was just an example, but in general, support for ISO 3166-3 might be useful if you need to reference countries that have been removed from ISO 3166-1. It looks like you already have the data but it's not yet implemented in the library.

@biter777
Copy link
Owner

@jakewilliami Could you do this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@biter777 @jakewilliami