Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the "safe bool" idiom to ConfigureQueueStatus #350

Open
hallfox opened this issue Jul 5, 2024 · 0 comments
Open

Apply the "safe bool" idiom to ConfigureQueueStatus #350

hallfox opened this issue Jul 5, 2024 · 0 comments
Labels
A-Client Area: C++ SDK bug Something isn't working

Comments

@hallfox
Copy link
Collaborator

hallfox commented Jul 5, 2024

The implicit operator bool conversion is not particularly safe, we prefer the unspecified bool type to help prevent implicit conversions to integral types. We do this for CloseQueueStatus, but we seemed to have missed it for this class.

@hallfox hallfox added bug Something isn't working A-Client Area: C++ SDK labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Client Area: C++ SDK bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant