Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-establish RuboCop usage for linting #101

Open
6 of 7 tasks
brettchalupa opened this issue Oct 14, 2022 · 1 comment
Open
6 of 7 tasks

Re-establish RuboCop usage for linting #101

brettchalupa opened this issue Oct 14, 2022 · 1 comment
Assignees
Labels

Comments

@brettchalupa
Copy link
Owner

brettchalupa commented Oct 14, 2022

Tasks:

  • be specific about RuboCop gem vers so it isn't a moving target
  • add minitest ext
  • address autocorrectable offenses
  • address other manual offenses
  • make default rake task run RuboCop for easy running w/ tests
  • document its usage in CONTRIBUTING
  • get it working on CI
@brettchalupa brettchalupa self-assigned this Oct 14, 2022
@brettchalupa brettchalupa added this to the v4 milestone Oct 14, 2022
@brettchalupa brettchalupa removed this from the v4 milestone Oct 26, 2022
@brettchalupa
Copy link
Owner Author

Having a heck of a time getting this working on CI due to unrelated require attempts within the RuboCop Rake task, see this branch: https://github.com/brettchalupa/graphql-docs/tree/rubocop

Putting this on hold as it's not a priority and is just nice to have for now

@brettchalupa brettchalupa added this to the v4.1 milestone Mar 13, 2023
@brettchalupa brettchalupa removed this from the v4.1 milestone Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

1 participant