Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Source trait on monsters in Tales from the Yawning Portal #302

Open
azuretower opened this issue Aug 24, 2017 · 5 comments
Open

Comments

@azuretower
Copy link

I see that the monsters from the Yawning Portal have their source listed as a trait instead of as part of the type. is this the new trend going forward? Why did you decide to make that change?

@snaggle2th
Copy link
Contributor

If so, that would be great! Currently, having the source in the Type field really messes up sorting by type in the GM5 app.

@azuretower
Copy link
Author

that's a good point, I hadn't considered sorting by type. It is probably a better place for that information.

@MattBerg11
Copy link

MattBerg11 commented Aug 24, 2017

What are the chances of changing source to its own section? Personally I have to go through and change this around manually to fit my projects needs.

<source>Tales from the Yawning Portal, 238</source>

@NeilMartin
Copy link
Contributor

I can think of a couple of good reasons why the source should be separated out into its own section.

  1. Including the source in an already established section intended for type, changes the meaning of that section and breaks software used to the old format. Adding it to a new section means it is simply ignored by old software that doesn't care about the source keyword.
  2. Merging sources. When an identical monster appears in more than one source, it needs to be identical in every aspect that matters. If you compare two monsters for equality with the intention of detecting duplicates, if their types are different, then they are different monsters. Including the source in the type would create two different types, which would incorrectly create two instances of the same monster.

@jurex
Copy link

jurex commented Oct 19, 2017

I can add source filters to Encounter+ app, if you guys decide to use source tag as @Shwaffle mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants