Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecated pinned dependencies in magic #10

Open
YtvwlD opened this issue Nov 28, 2018 · 1 comment
Open

deprecated pinned dependencies in magic #10

YtvwlD opened this issue Nov 28, 2018 · 1 comment

Comments

@YtvwlD
Copy link
Member

YtvwlD commented Nov 28, 2018 •
edited
Loading

yarn upgrade produces a few warnings. We should probably fix them.

warning react > fbjs > [email protected]: core-js@<2.6.8 is no longer maintained. Please, upgrade to core-js@3 or at least to actual version of core-js@2.

Edit: update list of warnings as of 14d3c59.
@3nt3
Copy link
Member

3nt3 commented Oct 26, 2019 •
edited
Loading

We can not just yarn install core-js@2 since is a dependency of react. To update core-js we would have to update react to ^16. Updating react would cause issues with elemental (which is not updated since 2017).

Warnings:

warning " > [email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning " > [email protected]" has incorrect peer dependency "react-dom@^0.14.0 || ^15.0.0".
warning " > [email protected]" has incorrect peer dependency "react@^15.4.2".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YtvwlD @3nt3