Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should we make testnets -> _testnets #734

Open
pyramation opened this issue Sep 19, 2022 · 3 comments
Open

should we make testnets -> _testnets #734

pyramation opened this issue Sep 19, 2022 · 3 comments

Comments

@pyramation
Copy link
Collaborator

since the assets are all w/o underscore it could create confusion, and additionally, the other folders (_IBC and _non-cosmos) have leading underscores.

@JeremyParish69
Copy link
Collaborator

to keep the change small, I think yes. However, ultimately, I think we should remove the underscore on all folders once the networks have been moved to a folder called 'mainnets'.

@pyramation
Copy link
Collaborator Author

I do agree about moving to mainnets — I think the previous convo around this was that the "landing page" has all the chains on it and makes it more useful. I honestly prefer the organized structure with testnets/, ibc/, mainnets/, but also see the reasoning for the other perspective.

It's hard because this repo is very "place oriented", but would benefit from structural organization

@pyramation
Copy link
Collaborator Author

So for now, I'd say we move testnets to _testnets, but try and re-visit the mainnets convo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants