Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeWishAggregateVersion and more than 3 wishes #24

Open
mcrio opened this issue Oct 28, 2018 · 0 comments
Open

makeWishAggregateVersion and more than 3 wishes #24

mcrio opened this issue Oct 28, 2018 · 0 comments

Comments

@mcrio
Copy link

mcrio commented Oct 28, 2018

Hi, thank you for the book. Just reading through the chapters.

In the book it was mentioned that there is a possibility that we end up with 3+ wishes in a rare case of parallel requests, although the business rule states there shouldn't be more than 3 wishes.

By moving the business logic to the user domain entity we do keep the logic in the domain which seems correct, but does it solve the problem above?

Also if the problem is to be solved somehow at the persistence layer, there the issue does not seem obvious without looking at the domain logic?

Maybe I'm missing something :)

https://github.com/dddinphp/last-wishes/blob/47cf7c5950734d8d90cd405432d5d20b2c897df3/src/Lw/Application/Service/Wish/AggregateVersion/AddWishService.php#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant