Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May I ask why not contribute these patches to upstream Qt? #135

Open
wangwenx190 opened this issue Mar 12, 2023 · 3 comments
Open

May I ask why not contribute these patches to upstream Qt? #135

wangwenx190 opened this issue Mar 12, 2023 · 3 comments

Comments

@wangwenx190
Copy link

No description provided.

@ilya-fedin
Copy link
Contributor

Personally I contribute patches authored by me, the problem is the process is stalled due to Qt developers ignoring the patch: https://codereview.qt-project.org/c/qt/qtbase/+/343628. This patch is the most basic in the sequence of changing default for better UX out-of-the-box (without playing with various Qt variables) and I decided to not to push the other changes until this one is merged (the logic is if they won't accept this one then they won't accept the other ones changing the defaults more obviously), but it stalled for two years.

But most patches are authored by @john-preston and he just has no time to participate in the Qt's bureaucratic process of reviews and rewriting patches in a way they would require.

@wangwenx190
Copy link
Author

Thanks for your reply! Sorry for my late reply due to I somewhat missed the email from GitHub.

It's sad to hear that patch is not accepted by Qt reviewers. But I'm mostly a Windows developer, I wonder why you don't contribute the Windows patches to Qt? They don't seem to be related to the Linux & macOS patches in this repo and they will not be blocked by the patch you mentioned above.

@ilya-fedin
Copy link
Contributor

As I said, most patches are authored by @john-preston and he just has no time for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants