-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to adjust the httpclient timeout for layer pushes #543
Comments
got the same issue, see Azure/azure-dev#3225 (comment) |
This also bit @mitchdenny hard today. |
Customers are hitting this repeatedly on the linked issue. We may need to bump priority + backport to 8.0.200 since Aspire is using that feature branch. cc @MichalPavlik / @rokonec / @rainersigwald |
I wonder if the issue isn't caused by the SDK not doing chunked uploads, see Azure/azure-dev#3212 (comment). |
We've got a hotfix in for 8.0.200 servicing and 8.0.300, but we should have some more usable knob. Moving this to the next milestone as a result. |
@baronfel is a fix for this in 8.0.1xx? |
No, I'm not sure why I didn't backport that far originally. Folks using 1xx can use the nuget packages for a workaround now, however. |
I kicked a backport off that I can get servicing approval for over email. |
Backport is dotnet/sdk#41294 |
Users aren't always in control of their network - we should provide some way for them to override the default .NET timeout for uploads (100s). This pops up in a few places, like Azure/azure-dev#3212.
Thoughts:
WaitAsync(TimeSpan)
methods onTask<T>
to make that super clear.WaitAsync
, those throwTimeoutException
s with little detail, so we should handle them and make them say something useful.cc @rainersigwald @MichalPavlik
The text was updated successfully, but these errors were encountered: