Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PublishContainer doesn't traverse the project tree (Microsoft.Build.Traversal) #594

Open
oats4goats opened this issue Sep 4, 2024 · 3 comments

Comments

@oats4goats
Copy link

Hey!

I use a .proj file in the root (generated by dotnet-affected tooling) to build and publish the affected projects in my tree.

I'm now exploring the PublishContainer target for my CI pipeline. And it seems to be checking isPublishable and EnableSdkContainerSupport props in the said .proj file (in the root) which are false by default and then skips publishing the containers altogether without traversing the tree.

Publishing the projects inside the tree works just fine. Is it an intended behavior?

Thanks for looking into this!

--
MItya

@oats4goats oats4goats changed the title PublishContainer doesnt'r traverse the project tree (Microsoft.Build.Traversal) PublishContainer doesn't traverse the project tree (Microsoft.Build.Traversal) Sep 4, 2024
@baronfel
Copy link
Member

baronfel commented Sep 4, 2024

You'd need to ask the traversal SDK folks why the target isn't forwarded along to the child projects.

@oats4goats
Copy link
Author

Got it! Thanks. Will report back.

@baronfel
Copy link
Member

baronfel commented Sep 4, 2024

Great! Interested in hearing what they think - in general if an action works for a solution we should be able to support it for a traversal project as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants