Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Not compatible with latest wetterdienst Version #1

Closed
deepweather opened this issue Feb 11, 2021 · 8 comments · Fixed by #2
Closed

Not compatible with latest wetterdienst Version #1

deepweather opened this issue Feb 11, 2021 · 8 comments · Fixed by #2
Assignees
Labels
bug Something isn't working

Comments

@deepweather
Copy link

deepweather commented Feb 11, 2021

Due to renaming of many classes and input parameters in the latest Version of wetterdienst package, the UI App does not work with the current wetterdienst release.

Examples:

DWDObservationSites -> DWDObservationStations
DWDObservationData -> DWDObservationValues
etc.

Working on a pull request!

@deepweather deepweather changed the title Not compatible with latest wettedienst Version Not compatible with latest wetterdienst Version Feb 11, 2021
@amotl
Copy link
Member

amotl commented Feb 11, 2021

Hi Marvin,

thank you very much!

Wetterdienst itself is very much in flux, so we appreciate that people are taking care. As mentioned at earthobservations/wetterdienst#347 (comment), the best thing to help that both code bases will not diverge too much would be to unify them into the same repository and cover both angles through the same test harness, following the monorepo paradigm.

However, because the contribution by @meteoDaniel just happened a few hours ago, that obviously hasn't happened yet. We are very happy that you are chiming in so quickly and are looking forward to your patch.

With kind regards,
Andreas.

@meteoDaniel
Copy link
Contributor

@deepweather are you finished with the refactoring? If you are working on that I would prefer to start with some of the open features to enhance the service. Let me know and thanks for contributing!

Btw. nice nickname ;)

@deepweather
Copy link
Author

deepweather commented Feb 12, 2021

Hey Andreas,
got it, thanks for explaining.

@meteoDaniel
Nope, unfortunately did not finish yesterday, I'll work on that after end of working day. Sure, thanks to everybody contributing to earthobservations for the nice tools!

👍 Thanks

Best,
Marvin

@gutzbenj
Copy link
Member

Hey guys,

actually I'm already working on further changes within the PR at [1]. However everything resulting from this PR will only simplify things in terms of jumping from a stations listing directly to the corresponding values ;) so, anyway, thanks for your effort on this side of the lib.

[1] earthobservations/wetterdienst#345

@meteoDaniel
Copy link
Contributor

This PR solves the most recent incompatibilities https://github.com/earthobservations/wetterdienst-ui/tree/update_wetterdiest_add_docker
@gutzbenj let me know if there is a new release on your side. I will make further adaptions.

@meteoDaniel meteoDaniel self-assigned this Mar 3, 2021
@meteoDaniel meteoDaniel added the bug Something isn't working label Mar 3, 2021
@meteoDaniel meteoDaniel linked a pull request Mar 3, 2021 that will close this issue
@gutzbenj
Copy link
Member

gutzbenj commented Mar 3, 2021

This PR solves the most recent incompatibilities https://github.com/earthobservations/wetterdienst-ui/tree/update_wetterdiest_add_docker
@gutzbenj let me know if there is a new release on your side. I will make further adaptions.

I'm still working on the new version (rather fixing the tests, docs,...)! Apparently it changes a lot so I'll have to make sure, that everything makes sense after all and has its defined place. After speaking with @amotl we will also do "one last big renaming" in order to give the new structure a more sensible name.

@meteoDaniel
Copy link
Contributor

@gutzbenj what are you thinking about for the renaming?

@gutzbenj
Copy link
Member

gutzbenj commented Mar 3, 2021

The renaming would only be from DWDObservationStations to DWDObservationRequest. However from this point further renamings won't effect any of the other code, as we'd go from this one class to the station listing, and from that again to the values.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants