-
Notifications
You must be signed in to change notification settings - Fork 0
Not compatible with latest wetterdienst Version #1
Comments
Hi Marvin, thank you very much! Wetterdienst itself is very much in flux, so we appreciate that people are taking care. As mentioned at earthobservations/wetterdienst#347 (comment), the best thing to help that both code bases will not diverge too much would be to unify them into the same repository and cover both angles through the same test harness, following the monorepo paradigm. However, because the contribution by @meteoDaniel just happened a few hours ago, that obviously hasn't happened yet. We are very happy that you are chiming in so quickly and are looking forward to your patch. With kind regards, |
@deepweather are you finished with the refactoring? If you are working on that I would prefer to start with some of the open features to enhance the service. Let me know and thanks for contributing! Btw. nice nickname ;) |
Hey Andreas, @meteoDaniel 👍 Thanks Best, |
Hey guys, actually I'm already working on further changes within the PR at [1]. However everything resulting from this PR will only simplify things in terms of jumping from a stations listing directly to the corresponding values ;) so, anyway, thanks for your effort on this side of the lib. |
This PR solves the most recent incompatibilities https://github.com/earthobservations/wetterdienst-ui/tree/update_wetterdiest_add_docker |
I'm still working on the new version (rather fixing the tests, docs,...)! Apparently it changes a lot so I'll have to make sure, that everything makes sense after all and has its defined place. After speaking with @amotl we will also do "one last big renaming" in order to give the new structure a more sensible name. |
@gutzbenj what are you thinking about for the renaming? |
The renaming would only be from DWDObservationStations to DWDObservationRequest. However from this point further renamings won't effect any of the other code, as we'd go from this one class to the station listing, and from that again to the values. |
Due to renaming of many classes and input parameters in the latest Version of wetterdienst package, the UI App does not work with the current wetterdienst release.
Examples:
DWDObservationSites -> DWDObservationStations
DWDObservationData -> DWDObservationValues
etc.
Working on a pull request!
The text was updated successfully, but these errors were encountered: