Skip to content
This repository has been archived by the owner on Aug 23, 2018. It is now read-only.

Javascript error for elm-package.json "repository" strings where the github username starts with a capital when built with '--debug' #128

Open
NickAger opened this issue Nov 16, 2016 · 3 comments

Comments

@NickAger
Copy link

NickAger commented Nov 16, 2016

Tested in 0.18

"repository": "https://github.com/user/project.git",

to:

"repository": "https://github.com/User/project.git",

that is user has changed to User.

TypeError: undefined is not an object (evaluating '_elm_lang$core$Native_Scheduler.nativeBinding')
  • The problem only occurs if the first character of the github username is capitalised.
  • There is no problem if compiling without the --debug flag; that is elm-make Buttons.elm works as expected.
  • Whereas elm-make --debug Buttons.elm generates the javascript error.
  • Tested on Safari 10.0.1 and Chrome 54.0.2840.98

Thanks to @lorenzo on slack for locating the issue for me.

@process-bot
Copy link

Thanks for the issue! Make sure it satisfies this checklist. My human colleagues will appreciate it!

Here is what to expect next, and if anyone wants to comment, keep these things in mind.

@NickAger NickAger changed the title Javascript error for long elm-package.json repositories strings for '--debug' Javascript error for long elm-package.json repositories strings when '--debug' enabled Nov 16, 2016
@NickAger NickAger changed the title Javascript error for long elm-package.json repositories strings when '--debug' enabled Javascript error for long elm-package.json "repository" strings when '--debug' enabled Nov 16, 2016
@NickAger NickAger changed the title Javascript error for long elm-package.json "repository" strings when '--debug' enabled Javascript error for long elm-package.json "repository" strings when built with '--debug Nov 16, 2016
@NickAger NickAger changed the title Javascript error for long elm-package.json "repository" strings when built with '--debug Javascript error for long elm-package.json "repository" strings when built with '--debug' Nov 16, 2016
@evancz
Copy link
Contributor

evancz commented Nov 17, 2016

What are other strings you tried? What is the length where it starts messing up?

@NickAger NickAger changed the title Javascript error for long elm-package.json "repository" strings when built with '--debug' Javascript error for elm-package.json "repository" strings where user starts with a capital when built with '--debug' Nov 17, 2016
@NickAger NickAger changed the title Javascript error for elm-package.json "repository" strings where user starts with a capital when built with '--debug' Javascript error for elm-package.json "repository" strings where the github username starts with a capital when built with '--debug' Nov 17, 2016
@NickAger
Copy link
Author

@evancz it turns out not to be related to the length of the repository string, rather to capitalising the initial letter of the github username in the repository string. So the default works:

"repository": "https://github.com/user/project.git",

whereas changing user to User causes the javascript exception:

"repository": "https://github.com/User/project.git",

I've edited the title and description to match.

NickAger added a commit to NickAger/elm-slider that referenced this issue Nov 17, 2016
…' so:

"repository": "https://github.com/NickAger/elm-slider.git",

caused a javascript error for `--debug`, whereas:

"repository": "https://github.com/nickager/elm-slider.git",

works fine - who would have thought it!

See logged issue: elm-lang/elm-make#128
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants