Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student Proposal: Improve pure Elm markdown parser #17

Open
LutSa opened this issue Apr 12, 2021 · 3 comments
Open

Student Proposal: Improve pure Elm markdown parser #17

LutSa opened this issue Apr 12, 2021 · 3 comments

Comments

@LutSa
Copy link

LutSa commented Apr 12, 2021

Improve pure Elm markdown parser

Name: Jinyi Wu
Nick in the Elm Slack: Lut
Possible mentor: Dillon Kearns @dillonkearns

Summary

This project is based on the idea Improve pure Elm markdown parser.

As the idea described, some specs of the pure Elm markdown parser dillonkearns/elm-markdown are not yet implemented. So, the goal is to complete the current implementation of Github-flavored markdown style, get the automated spec tests passing, and clarify places where it needs to diverge from the spec because of its specific handling of HTML for extensibility.

How will I achieve this

I will follow the current contribution guide, elm-markdown’s philosophy and goals. I will be driven by the GFM test suite. I will document when and how to fail some cases and provide helpful errors. I will try to reach high performance (like using less ‘backtrackable’).

What will the project focus on

The project will focus on the GFM spec and helpful errors.

Benefits

The idea of dillonkearns/elm-markdown is awesome, see Dillon’s blog. And it is currently used for a lot of elm-pages applications. So many users and developers will benefit from the helpful errors and complete specs provide by this GSOC project.

Timeline

Based on the automated spec test suite, the task of this project is quite specific and easy to break down into subtasks and the process of this project is manageable.

Weeks of May 18 - June 8 (Community bonding)

To be more specific, I will discuss my solutions for the top3 challenging GFM specs (I’ll have 1-3 solutions to each issue) and the design of when to provide helpful errors with the markdown community and my mentor. And from there, I will determine whether the implementation of some extremely difficult specs is optional depend on its risk. For other required but difficult specs, I will get my mind more clear about the implementation at a high level and prepared for the coding.

I’ve seen the current elm-markdown’s implementation and CommonMark’s official implementations which have many differences. So, I will continue to investigate other markdown parsing works’ implementation and handle of errors, particularly those implemented in functional language and have errors.

What I will do in this period but not limited to this period: I will learn more about the elm ecosystem, its toolchains, its packages, its development ideas… And I also will try to learn from and contribute to the community. Especially, I find myself quite interested in other students’ projects and hope to communicate with them.

Weeks of June 8 - June 21

I will implement GFM extension specs Autolinks. I will solve the issue of Thematic precedence, which might be a good start point to the lists specs. And I will solve any other minimal failing GFM spec test cases that are discovered as possible.

Weeks of June 22 - July 16

Based on the previously discussed solutions, I will focus on the improvements of the current implementation of container blocks (Block quote, List, and List Item), as well as link reference definitions. And I will try to provide complete entity, which is previously troubled by elm’s large list problem.

July 13 - July 17 (First Evaluation)

For the first evaluation, I will all basic specs implemented and get my work reviewed by the mentor and the community to get feedback. I will publish the write-ups of my development process.

Weeks of July 17 - July 31

I will pass the remaining minimal failing GFM spec test cases. And I will focus on the failing cases with helpful errors, the Html blocks, and inline raw Html.

Weeks of August 1 - August 16

I will adjust the current documents to including new specs and failing cases with help errors. I will document clearly where it derives from GFM. I will update the current examples and write a tiny example to illustrate new spec and failing cases. I will give my idea about how this project can further be improved, like for its extensibility, failing cases, performance.

August 17 - August 24 (Code Submission and Final Evaluation)

I will get my final project reviewed by my mentor and the community to get feedback. I will publish all my write-ups and a summary of my experience.

Goals

Just as the idea, the goal is to try the automated spec tests passing and clarify places where it needs to diverge from the spec because of its specific handling of HTML for extensibility. But for some extremely difficult specs, I will discuss those with my mentor, determine whether it is optional and refine my goals before the coding period.

Requirements

Elm, parsing, markdown

@dillonkearns
Copy link
Contributor

Thanks for the proposal @LutSa!

I think the most difficult, and also the most important, parsing feature will be nested list parsing: dillonkearns/elm-markdown#7. Someone did some preliminary research on that, so we can get some context from them on what they discovered there.

I think it would be a good goal to work on a couple of easier features in the first couple of weeks to get comfortable in the codebase and with elm/parser. And then hopefully start the initial investigation for the nested list parsing soon after that.

@dillonkearns
Copy link
Contributor

I think this issue could also be in the top 3 most difficult remaining features: dillonkearns/elm-markdown#60.

@LutSa
Copy link
Author

LutSa commented Apr 12, 2021

Thanks for the helpful feedback @dillonkearns!

Exactly. I also find this most difficult. I put it in the first week because I think it is a more fundamental problem and I hope I can have a clear high-level strategy before the first week. And a few of core problems are so challenging that I even have ignored some easier features...

You're right. I need a smoother curve to complete this project.

Now I have these subtasks for the first period:

  • implement GFM extension specs Autolinks

  • solve the issue of Thematic precedence, which might be a good start point to the lists specs

  • solve any other minimal failing GFM spec test cases that are discovered as possible

And I plan to shorten the first period to exactly two weeks so that we will have three weeks for the second period.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants