Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAT traversal #596

Closed
7 of 8 tasks
emhane opened this issue Mar 16, 2023 · 11 comments
Closed
7 of 8 tasks

NAT traversal #596

emhane opened this issue Mar 16, 2023 · 11 comments
Assignees
Labels

Comments

@emhane
Copy link
Member

emhane commented Mar 16, 2023

Optimised protocol based off ethereum/devp2p#207
Relating to issue: ethereum/devp2p#226

@carver
Copy link
Collaborator

carver commented Mar 20, 2023

Work happening here: https://github.com/emhane/discv5/commits/nat-hole-punch

@emhane
Copy link
Member Author

emhane commented Mar 27, 2023

@carver
Copy link
Collaborator

carver commented Mar 27, 2023

When following the docs, I get this for the first server attempt:

error: Found argument 'query' which wasn't expected, or isn't valid in this context

I think it started up fine by just removing query. I haven't finished running the test, though.

@carver
Copy link
Collaborator

carver commented Mar 27, 2023

Hm, the second cli instance doesn't recognize -u, -i, or -r, so I sense that I'm doing something really wrong. I'm not seeing those options in cargo run -p discv5-cli -- server -h. I'm running commit aa52bbd2879c83257

@emhane
Copy link
Member Author

emhane commented Mar 28, 2023

But the latest commit at origin/nat is 8feb22ede3203e567bfcae4071f117c6eae472c0 ?

@carver
Copy link
Collaborator

carver commented Mar 29, 2023

yup, I'm a goof, that's why we post commit hashes! :P

@carver
Copy link
Collaborator

carver commented Apr 3, 2023

sigp/discv5#134

@KolbyML
Copy link
Member

KolbyML commented Apr 16, 2023

After this is done we can look at closing this issue #22 since this would be the solution to it?

@emhane
Copy link
Member Author

emhane commented Apr 17, 2023

After this is done we can look at closing this issue #22 since this would be the solution to it?

That's right, both issues tackle the same general problem of how to include nodes behind NAT in the network.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

This issue is stale because it has been open for 42 days with no activity.

@github-actions github-actions bot added the stale label Sep 3, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants