Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linked-list: contains test case that doesn't match exercise insturction #2131

Open
bupjae opened this issue Mar 16, 2022 · 2 comments
Open

linked-list: contains test case that doesn't match exercise insturction #2131

bupjae opened this issue Mar 16, 2022 · 2 comments
Labels
x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Comments

@bupjae
Copy link

bupjae commented Mar 16, 2022

Exercise instruction says this:

Specifically: pop or shift will never be called on an empty list.

However, prototype of List contains PopBack() (interface{}, error) and PopFront() (interface{}, error), which suggests that we should return error object when list was empty. Test cases also asserts that correct error object is returned when list was empty.

I opened this issue here because test cases on problem specifications repository doesn't have this issue.
@junedev
Copy link
Member

junedev commented Mar 21, 2022

Thanks for bringing this up. We might want to keep the current code in the track but in any case the instructions.append.md file should describe any of those differences. This is missing currently.

@junedev junedev added x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work labels Mar 21, 2022
@sbshah97
Copy link

Hi,

I'd like to help on this if that is okay.

@sbshah97 sbshah97 mentioned this issue Mar 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing instructions added for go linked list sbshah97/exercism-go
3 participants
@bupjae @junedev @sbshah97