Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement repeatable multi-sources #57

Open
jannden opened this issue Sep 13, 2024 · 0 comments
Open

Implement repeatable multi-sources #57

jannden opened this issue Sep 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jannden
Copy link
Contributor

jannden commented Sep 13, 2024

Suggestion by @sirewix from here:

If our code deals with multiple sources in the same run, it doesn't make sense why there could be at most one source of the same kind, but few of different kinds.

That is, instead of:

pub struct Config {
	pub sources: SourcesConfig,
	// ...
}
pub struct SourcesConfig {
	pub ldap: Option<LdapSourceConfig>,
	pub ukt: Option<UktSourceConfig>,
	pub csv: Option<CsvSourceConfig>,
}

To have something like:

pub struct Config {
	pub sources: Vec<AnySourceConfig>,
	// ...
}

enum AnySourceConfig {
  Ldap(LdapSourceCofnig),
  Ukt(UktSourceConfig),
  Csv(CsvSourceConfig),
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants