Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split apart e2e tests for the different sources #60

Open
tlater-famedly opened this issue Sep 16, 2024 · 0 comments
Open

Split apart e2e tests for the different sources #60

tlater-famedly opened this issue Sep 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@tlater-famedly
Copy link
Contributor

tlater-famedly commented Sep 16, 2024

          I added a test that combines LDAP and UKT syncing into one as per your suggestion. Also, as per your suggestion in another comment, let's postpone the division of tests for another PR.

Originally posted by @jannden in #49 (comment)

This would be nice to do before we start adding more sources, as the e2e test file will just keep growing if we don't get to this.

In addition, we should see if using nextest's test group feature makes sense here, since the non-ldap tests would not need an LDAP server to run, so if a specific subset of tests is run we could save ourselves the effort of spinning that up.

@nikzen nikzen added the enhancement New feature or request label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants