Did I brake data grepper?

[praiskup]

This is meant to be a question rather than issue.

I'm trying to play with fedora-messaging, which seems to correctly forward messages to fedmsg, so it ens in datagrepper. Though I probably underestimated my playing, and sent a mesage with topic=u'copr.nice.message' to staging bus...
And now data grepper tracebacks:
https://apps.stg.fedoraproject.org/datagrepper/raw?category=copr&delta=172800

{"detail":"","error":"internal_error","traceback":"Traceback (most recent call last):\n  File \"/usr/lib/python2.7/site-packages/flask/app.py\", line 1817, in wsgi_app\n    response = self.full_dispatch_request()\n  File \"/usr/lib/python2.7/site-packages/flask/app.py\", line 1477, in full_dispatch_request\n    rv = self.handle_user_exception(e)\n  File \"/usr/lib/python2.7/site-packages/flask/app.py\", line 1381, in handle_user_exception\n    reraise(exc_type, exc_value, tb)\n  File \"/usr/lib/python2.7/site-packages/flask/app.py\", line 1475, in full_dispatch_request\n    rv = self.dispatch_request()\n  File \"/usr/lib/python2.7/site-packages/flask/app.py\", line 1461, in dispatch_request\n    return self.view_functions[rule.endpoint](**req.view_args)\n  File \"/usr/lib/python2.7/site-packages/datagrepper/app.py\", line 421, in raw\n    message = message_card(msg, size)\n  File \"/usr/lib/python2.7/site-packages/datagrepper/util.py\", line 117, in message_card\n    subtitle = fedmsg.meta.msg2subtitle(msg, legacy=False, **config)\n  File \"/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py\", line 152, in __wrapper\n    return f(msg, **config)\n  File \"/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py\", line 171, in __wrapper\n    return f(msg, processor=processor, **config)\n  File \"/usr/lib/python2.7/site-packages/fedmsg/meta/__init__.py\", line 246, in msg2subtitle\n    return processor.subtitle(msg, **config)\n  File \"/usr/lib/python2.7/site-packages/fedmsg_meta_fedora_infrastructure/coprs.py\", line 130, in subtitle\n    raise NotImplementedError()\nNotImplementedError\n"}

In Copr, as a first step, we plan to send "compatible" messages so we won't actually break datagrepper at the beginning -- though I'm curious whether I still have to update the fedmsg meta coprs.py file if I design some new message.... or we are simply OK to break fedmsg here .... and I should only keep the schema in fedora-messaging schema.

[praiskup]

... or, is fedmsg schema updated automatically if I define fedora-messaging schema?

[jeremycline]

It seems really wrong for the service to dump tracebacks to users in production so I'd say that's probably a bug.

I didn't even realize datagrepper was using fedmsg meta stuff. The schema package for Copr is supposed to replace the functionality of fedmsg-meta (pretty-printing, determining affected users/packages/etc), but at the moment neither fmn nor datagrepper install or try to use the schema packages. They're still using the fedmsgs and fedmsg-meta.

What I'd recommend is fixing datagrepper to make use of the schema packages rather than spending time on fedmsg-meta, since that's going to be abandoned once people all have schema packages.