-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not Recognizing Moves in Collections #108
Comments
To clarify, the result is |
I'm pretty comfortable closing this, unless anyone wants to pick up the discussion and try to formalize the different strategies and/or how to implement them...? |
Since the current implementation is technically correct, but I would argue that what I was looking for would be "more correct". |
Oh I don't disagree (maybe just about the "level of correctness" assertion), and this can definitely by a worthwhile feature requests, but I think it bears defining a bit more carefully what these options are designed to accomplish. |
Expected Behavior
If an entry in a collection changes index in a collection, it should be reported as a move.
Actual Behavior
It is being reported as a replace.
Steps to Reproduce the Problem
JsonDiff.asJson(new ObjectMapper().valueToTree("[1, 2, 3]"), new ObjectMapper().valueToTree("[2, 1, 3]"));
Specifications
zjsonpatch 0.4.9
Java 1.8
jackson 2.9.7
The text was updated successfully, but these errors were encountered: