Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] file.append makedirs doesn't work. #112

Open
johnmckenna-snd opened this issue Aug 19, 2024 · 5 comments
Open

[BUG] file.append makedirs doesn't work. #112

johnmckenna-snd opened this issue Aug 19, 2024 · 5 comments
Assignees
Labels
bug Something isn't working Unlabeled Requires sorting

Comments

@johnmckenna-snd
Copy link
Contributor

Please describe the issue.
If try to make a file and it's directories it doesn't wok.

# doesn't work where prom-config doesn't exist
# returns error: ERROR        json: cannot unmarshal object into Go struct field StepCompletion.Error of type error        listener.go:74
steps:
  create-boilerplate-file:
    file.append:
      - name: /home/sensor/prom-config/prometheus.yml
      - makedirs: true
      - text: "boilerplate"

# this works if it only has to create the file
steps:
  create-boilerplate-file:
    file.append:
      - name: /home/sensor/prometheus.yml
      - makedirs: true
      - text: "boilerplate"

Does this bug exist on the tip of master?
[x] Yes
[ ] No

Please note that bugfixes will only be ported to previous major versions at the request of a Sponsor, and only when applicable and possible.
It is recommended all grlx users run the lastest stable release to take advantage of the newest features and bug fixes.

Configuration

Please upload the configuration files used if applicable.

@johnmckenna-snd johnmckenna-snd added bug Something isn't working Unlabeled Requires sorting labels Aug 19, 2024
@taigrr
Copy link
Member

taigrr commented Aug 19, 2024

if you're willing to test drive #d32e19b it should address this issue (tip of dev branch)

@johnmckenna-snd
Copy link
Contributor Author

i can do that! probably in the next week or so.

@taigrr
Copy link
Member

taigrr commented Aug 19, 2024

Cool. I am unable to publish a new version of grlx just yet, I've made a few API breaking changes to exported functions so the next release will be a v2 / major release. I'm trying to figure out all of my API breaking changes at once so I'm not at version 300 by the end of the year a la Kubernetes 😆

@johnmckenna-snd
Copy link
Contributor Author

Ok sounds good! I am looking forward to it.

@johnmckenna-snd
Copy link
Contributor Author

I just wanted to follow up here. I have not had the time to check this out, but I should soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Unlabeled Requires sorting
Projects
None yet
Development

No branches or pull requests

2 participants