From c45599dd1bb7bd206f8c898a497705bfbbc7007f Mon Sep 17 00:00:00 2001 From: Matthias Cram Date: Wed, 3 Aug 2022 16:02:11 +0200 Subject: [PATCH] don't build notes in squello that were created on github --- .../SPBColumn.class/instance/fetchAndBuildSingleCard..st | 2 +- Squello-Core.package/SPBColumn.class/methodProperties.json | 2 +- .../instance/createSingleCard.into..st | 4 ++++ .../SPBGithubBoardProvider.class/methodProperties.json | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/Squello-Core.package/SPBColumn.class/instance/fetchAndBuildSingleCard..st b/Squello-Core.package/SPBColumn.class/instance/fetchAndBuildSingleCard..st index 67f854a6..67b717bc 100644 --- a/Squello-Core.package/SPBColumn.class/instance/fetchAndBuildSingleCard..st +++ b/Squello-Core.package/SPBColumn.class/instance/fetchAndBuildSingleCard..st @@ -1,5 +1,5 @@ creation fetchAndBuildSingleCard: aNumber - self boardProvider createSingleCard: aNumber into: self. + self boardProvider createSingleCard: aNumber into: self self alignCards. \ No newline at end of file diff --git a/Squello-Core.package/SPBColumn.class/methodProperties.json b/Squello-Core.package/SPBColumn.class/methodProperties.json index 0ddb524b..17ee1b5f 100644 --- a/Squello-Core.package/SPBColumn.class/methodProperties.json +++ b/Squello-Core.package/SPBColumn.class/methodProperties.json @@ -36,7 +36,7 @@ "defaultWidth" : "LW 7/14/2022 11:18", "deleteCard:" : "jh 7/9/2022 18:05", "fetchAndBuildCards" : "mcr 8/3/2022 13:59", - "fetchAndBuildSingleCard:" : "mcr 8/3/2022 14:49", + "fetchAndBuildSingleCard:" : "mcr 8/3/2022 15:59", "hash" : "LW 7/14/2022 11:12", "hideIndicator" : "NTK 7/30/2022 12:15", "id" : "tkv 5/21/2022 00:59", diff --git a/Squello-Core.package/SPBGithubBoardProvider.class/instance/createSingleCard.into..st b/Squello-Core.package/SPBGithubBoardProvider.class/instance/createSingleCard.into..st index 1224e69b..baa9bbde 100644 --- a/Squello-Core.package/SPBGithubBoardProvider.class/instance/createSingleCard.into..st +++ b/Squello-Core.package/SPBGithubBoardProvider.class/instance/createSingleCard.into..st @@ -4,4 +4,8 @@ createSingleCard: aNumber into: anSPBColumn | cardJson | cardJson := self api querySingleCard: aNumber. + "at the moment we can just display issues and pull requests. + If a a note is added on github (than it has no content_url) it it won't be build" + (cardJson at: 'content_url') ifNil: [^ self]. + ^ SPBCard buildNewFromRemote: cardJson into: anSPBColumn. \ No newline at end of file diff --git a/Squello-Core.package/SPBGithubBoardProvider.class/methodProperties.json b/Squello-Core.package/SPBGithubBoardProvider.class/methodProperties.json index 767915cf..d6441c8b 100644 --- a/Squello-Core.package/SPBGithubBoardProvider.class/methodProperties.json +++ b/Squello-Core.package/SPBGithubBoardProvider.class/methodProperties.json @@ -11,7 +11,7 @@ "createCardsFromColumn:" : "mcr 8/3/2022 15:41", "createColumn:" : "jh 7/31/2022 13:54", "createNewCard:into:" : "mcr 8/3/2022 13:59", - "createSingleCard:into:" : "mcr 8/3/2022 14:54", + "createSingleCard:into:" : "mcr 8/3/2022 16:01", "deleteAssignee:fromCard:" : "LW 7/30/2022 15:42", "deleteLabel:fromCard:" : "lo 7/13/2022 19:44", "getProjects:" : "jh 7/31/2022 14:13",