Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in accuracy question #2

Closed
adam-hartshorne opened this issue Sep 18, 2022 · 2 comments
Closed

Difference in accuracy question #2

adam-hartshorne opened this issue Sep 18, 2022 · 2 comments

Comments

@adam-hartshorne
Copy link

It appears somebody else has written a pull request for an implementation of the Adan optimizer for Optax. I pointed out that your implementation already existed and it is claimed that in testing that your version is "3 order of magnitude larger error".

google-deepmind/optax#401

Is there potentially a bug in your code?

@hr0nix
Copy link
Owner

hr0nix commented Sep 18, 2022

Thanks for pointing that out! I'll take a look

@hr0nix
Copy link
Owner

hr0nix commented Sep 18, 2022

Took a look at it, the difference comes from where epsilon is placed: google-deepmind/optax#401 (comment)

Not sure if that's important, but I'll push this change so that this implementation is more similar to reference.

@hr0nix hr0nix closed this as completed Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants