Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants instead of arbitrary ints in the code #1096

Open
mgrundkoetter opened this issue Aug 8, 2024 · 1 comment
Open

Use constants instead of arbitrary ints in the code #1096

mgrundkoetter opened this issue Aug 8, 2024 · 1 comment

Comments

@mgrundkoetter
Copy link

In the class In2code\Powermail\Domain\Validator\InputValidator in isValidFieldInStringValidation some "random" ints are used to identify the validator. This is bad style from a static analysis point of view and should be replaced by public constants in this class which can then also be used in derived classes.

@mschwemer mschwemer self-assigned this Aug 15, 2024
@mschwemer
Copy link
Collaborator

Thanks. This is correct :-)

We plan to introduce static analysis in the next weeks for powermail and will consider it to improve the situation here.

@mschwemer mschwemer removed their assignment Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants