Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with HTTP2 shading #218

Open
Goksi opened this issue Mar 23, 2023 · 4 comments
Open

Issue with HTTP2 shading #218

Goksi opened this issue Mar 23, 2023 · 4 comments
Assignees
@zugazagoitia

Comments

@Goksi
Copy link

Goksi commented Mar 23, 2023 •
edited
Loading

Describe the bug
While shading javalin ssl inside of spigot plugin, hpack http2 class is not included inside of ServiceLoaders, resulting
ERR_CONNECTION_CLOSED
Fixed by adding org.apache.maven.plugins.shade.resource.ServicesResourceTransformer transformer. Docs should be updated accordingly.

Screenshots
image
@zugazagoitia
Copy link
Member

@tipsy assign me and I'll work on it over the weekend (can't assign myself)

@zugazagoitia
Copy link
Member

The docker tutorial #177 should also be reviewed.

javalin/javalin#1840 is relevant here.

@tipsy
Copy link
Member

tipsy commented Mar 23, 2023

Done, thanks !

@tipsy
Copy link
Member

tipsy commented Nov 9, 2023

Pretty long weekend @zugazagoitia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zugazagoitia zugazagoitia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tipsy @zugazagoitia @Goksi