Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue: NPM Audit #41

Open
stevendesu opened this issue Dec 3, 2019 · 0 comments
Open

Minor issue: NPM Audit #41

stevendesu opened this issue Dec 3, 2019 · 0 comments

Comments

@stevendesu
Copy link

I just got around to making a pull request but was beaten to the punch by @leonklingele

In the process of forking, cloning, NPM installing, and starting to work, I noticed the following from npm audit:

found 321 vulnerabilities (3 low, 2 moderate, 314 high, 2 critical) in 11672 scanned packages
  run `npm audit fix` to fix 318 of them.
  3 vulnerabilities require manual review. See the full report for details.

Running npm audit fix updates jsdoc from ^3.4.3 to ^3.6.3 and resolves 318 of the issues

The remaining 3 issues are all "low" severity and all derive from the braces sub-dependency (used by both qunitjs and rollup-watch). Since they're both pulling in braces from micromatch, it may make more sense for micromatch to update those? I'm not entirely sure what the process is when a sub-dependency has a security issue like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant