Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA enabled account skipping 2FA code sign-in when logging in with OAuth provider #346

Closed
mystyq opened this issue Mar 24, 2024 · 1 comment
Labels
bug Something isn't working needs more info

Comments

@mystyq
Copy link

mystyq commented Mar 24, 2024

Stack

Jetstream – Livewire

Package Version

^6.0

Laravel Version

11

Livewire Version

No response

react Version

No response

Vue Version

No response

PHP Version

8.3.4

Problem description

2FA enabled account skips the 2FA code check when signing in with OAuth provider (google in my context)

Expected behavior

2FA enabled account should prompt for code before signing in using OAuth flow

Steps to reproduce

  1. Create account
  2. Enable 2FA
  3. Connect Google account with same email
  4. Log-out
  5. Log in with Google account

Reproduction repository

https://github.com/joelbutcher/socialstream

Relevant log output

No response

@mystyq mystyq added the bug Something isn't working label Mar 24, 2024
Copy link

Hey @mystyq! We're sorry to hear that you've hit this issue. 💙

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Socialstream code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info
Projects
None yet
Development

No branches or pull requests

1 participant