Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Jitter in toxic attributes. #4

Open
jpittis opened this issue Mar 6, 2018 · 2 comments
Open

Support Jitter in toxic attributes. #4

jpittis opened this issue Mar 6, 2018 · 2 comments

Comments

@jpittis
Copy link
Owner

jpittis commented Mar 6, 2018

No description provided.

@ror6ax
Copy link

ror6ax commented Mar 16, 2018

Hi, I'd like to take this one up as fist Haskell OSS involvement. Would you be willing to answer some stupid questions if I'll need some help? ;)

@jpittis
Copy link
Owner Author

jpittis commented Mar 16, 2018

For sure @ror6ax. Check out the different types of the toxic attributes found on official Toxiproxy toxics. You'll find that some of them require floating points which are not currently supported by this library. I'm not sure how much more complex the solution is than just changing the toxic attribute value type to be an Either Int Float rather than an Int.

@jpittis jpittis assigned jpittis and unassigned jpittis Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ror6ax @jpittis