Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset account password #8

Open
liamjack opened this issue Mar 1, 2016 · 8 comments
Open

Reset account password #8

liamjack opened this issue Mar 1, 2016 · 8 comments
Labels

Comments

@liamjack
Copy link
Owner

liamjack commented Mar 1, 2016

No description provided.

@liamjack liamjack added the todo label Mar 1, 2016
@colinajd
Copy link

I would love to contribute and I was wondering, what behaviour you want for password resets?

@liamjack
Copy link
Owner Author

I was thinking of using JWT in the same way it is used for the activation email, just need to ensure that the token validity is pretty short (10 minutes ?).

@colinajd
Copy link

Ok yeah I already started doing that. I was thinking that it would be good to return the same message whether or not the user email is found but just add an attempt or something.

@liamjack
Copy link
Owner Author

Absolutely, I need to think about the whole attempt system before implementing.

@colinajd
Copy link

Whenever you get time you could put up some idea of implementation, and I could start work

@liamjack
Copy link
Owner Author

Sure I'll try and find some time this evening and get back to you :)

@liamjack
Copy link
Owner Author

Maybe just a basic database table with ip_hash, count and last_attempt_date: ip_hash being a secure hash of the visitor's IP address (salted) so that the information remains non-identifying, count being the number of attempts and last_attempt_date being the datetime of the last failed attempt, to decide whether to forget about previous attempts if older than a pre-defined time (1 hour ?) or to increment.

@colinajd
Copy link

colinajd commented Dec 6, 2016

Okay cool, I should have some stuff ready for a PR at some point soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants