Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move invoice utilities to ChannelManager #3375

Open
TheBlueMatt opened this issue Oct 16, 2024 · 0 comments
Open

Move invoice utilities to ChannelManager #3375

TheBlueMatt opened this issue Oct 16, 2024 · 0 comments
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@TheBlueMatt
Copy link
Collaborator

TheBlueMatt commented Oct 16, 2024

I thought I already opened an issue for this, but apparently not. Now that we swapped the dependency order between lightning-invoice and lightning we can also move the crap we shoved in lightning::ln::bolt11_payment into ChannelManager (possibly leaving the code in a separate file), making paying BOLT 11 invoices the same first-class citizen as paying BOLT 12 invoices. We might also consider moving ln::invoice_utils into some kind of builder pattern (or something where we pass a configuration object to ChannelManager and it spits out a BOLT 11) like we have for BOLT 12.

@TheBlueMatt TheBlueMatt added the Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
Development

No branches or pull requests

1 participant