Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Support] - Push Down 'position' declaration #365

Open
Ginger-Panda opened this issue Nov 11, 2019 · 0 comments
Open

[Support] - Push Down 'position' declaration #365

Ginger-Panda opened this issue Nov 11, 2019 · 0 comments

Comments

@Ginger-Panda
Copy link

if (widget.pushDown) {

We had a customer not too long ago inform us that pushDown didn't work when specifying top as the position of a bar layout modal. Upon some testing and digging I've confirmed that when using top we get the console error from line 471 in the method above... and upon checking some of the code, found the function referenced above. It looks like the function is looking for either top-fixed or top-absolute, where our Pathfora docs (http://lytics.github.io/pathforadocs/layouts/bar/#pushdown) reference the top-absolute as simply top. So the check is failing.

I think we need to either or both:
Adjust the function to allow for top
Adjust our documentation to specify top-absolute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant