Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect line number formatting #46

Open
mvllow opened this issue Sep 21, 2023 · 2 comments
Open

Respect line number formatting #46

mvllow opened this issue Sep 21, 2023 · 2 comments

Comments

@mvllow
Copy link
Owner

mvllow commented Sep 21, 2023

Bold (and possibly italic or other styles) are removed when the line number highlight changes. The correct format is restored once modes is no longer changing the line number highlight.

Can be reproduced via:

:set termguicolors
:colorscheme lunaperche
:set number
:set cursorline

The active line number should be bold by default. Once using a modes modifier, e.g. y, the entire line changes to yellow and the line number is no longer bold.

@fitrh
Copy link
Collaborator

fitrh commented Sep 21, 2023

I think this also requires refactoring all :highlight instances with nvim_set_hl. I've always used neovim nightly so I don't remember exactly when nvim_set_hl and nvim_get_hl were introduced. If we decided to refactor, I think we also need to mention the minimum required neovim version

@mvllow
Copy link
Owner Author

mvllow commented Sep 21, 2023

Looks like those were added in 0.9.0 via neovim/neovim#22693. This issue isn't that important to me personally as I usually don't have line numbers on. Maybe I can revisit this in the future unless someone wants to take it on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants