Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise code gen for enums #270

Open
bocchino opened this issue Jun 29, 2023 · 0 comments
Open

Revise code gen for enums #270

bocchino opened this issue Jun 29, 2023 · 0 comments
Labels
code generation Issues related to code generation

Comments

@bocchino
Copy link
Collaborator

  • Put the representation type in the C++ enum, i.e., write enum Foo : U8 { ... } instead of enum Foo { ... }.
  • Consider using enum classes instead of enums wrapped inside structs. The approach seems cleaner, as long as it doesn't break anything.
@bocchino bocchino added proposed feature A proposed new feature code generation Issues related to code generation labels Jun 29, 2023
@bocchino bocchino removed the proposed feature A proposed new feature label Jun 29, 2023
@bocchino bocchino mentioned this issue Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code generation Issues related to code generation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bocchino