Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust AssetUsageProjection to use workspace instead of content stream id #5084

Closed
mhsdesign opened this issue May 21, 2024 · 0 comments · Fixed by #5258
Closed

Adjust AssetUsageProjection to use workspace instead of content stream id #5084

mhsdesign opened this issue May 21, 2024 · 0 comments · Fixed by #5258
Assignees
Labels

Comments

@mhsdesign
Copy link
Member

mhsdesign commented May 21, 2024

The AssetUsage needs to switch from contentStreamId to WorkspaceName from Projection until all depending DTOs.

  • AssetUsageProjection
  • AssetUsage
  • AssetUsageFilter
  • AssetUsageReference

With #5002 we have access to the WorkspaceName in the projections instead of only the ContentStreamId.

That means we can adjust the write side + read side. And the chain down to the AssetUsageReference incl. AssetUsageFilter. To use workspace names.

final readonly class AssetUsageNodeAddress
{
    public function __construct(
-       public ContentStreamId $contentStreamId,
+       public WorkspaceName $workspaceName,
        public DimensionSpacePoint $dimensionSpacePoint,
        public NodeAggregateId $nodeAggregateId,
    ) {
    }
}

... as well as the AssetUsage class.

Should fix the following todos and problematic usages of the contentStreamId:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: In Progress
3 participants